Add cacheline-alignment to compiler/threading and switch from volatile to std::atomic#1005
Open
blonded04 wants to merge 5 commits intoVKCOM:masterfrom
Open
Add cacheline-alignment to compiler/threading and switch from volatile to std::atomic#1005blonded04 wants to merge 5 commits intoVKCOM:masterfrom
blonded04 wants to merge 5 commits intoVKCOM:masterfrom
Conversation
Signed-off-by: Valery Matskevich <generalretcher@gmail.com>
Signed-off-by: Valery Matskevich <generalretcher@gmail.com>
Signed-off-by: Valery Matskevich <generalretcher@gmail.com>
mkornaukhov
suggested changes
May 24, 2024
Contributor
mkornaukhov
left a comment
mkornaukhov
left a comment
There was a problem hiding this comment.
Please, do not break blame
| int i = (unsigned)hash % (unsigned)N; | ||
| while (true) { | ||
| while (nodes[i].hash != 0 && nodes[i].hash != hash) { | ||
| while (nodes[i].hash.load(std::memory_order_acquire) != 0 && nodes[i].hash.load(std::memory_order_relaxed) != hash) { |
Contributor
There was a problem hiding this comment.
Why second read is relaxed?
Author
There was a problem hiding this comment.
because it won't be reordered between nodes[i].hash.load(std::memory_order_acquire) before and nodes[i].hash.load(std::memory_order_acquire) after, the only barrier needed here is load-load, which is imposed by reading node hash
Signed-off-by: Valery Matskevich <generalretcher@gmail.com>
Signed-off-by: Valery Matskevich <generalretcher@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor compiler/threading:
std::atomicinstead ofvolatilealignasto cache-align shared structs